feat: adding `ConsensusHost` interface for custom self client/consensus state validation (backport #6055) #6547

mergify · 2024-06-10T13:10:03Z

Description

Co-authored-by: chatton github.qpeyb@simplelogin.fr

Adds the ConsensusHost interface type to 02-client as well as implementation for 07-tendermint and 08-wasm.

closes: #5315

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Summary by CodeRabbit

New Features
- Improved blockchain interoperability by introducing a WasmConsensusHost struct for wasm-wrapped consensus in the IBC package.
Tests
- Ensured reliability and robustness through extensive testing of the new wasm consensus mechanism in diverse scenarios.

This is an automatic backport of pull request #6055 done by [Mergify](https://mergify.com).

…us state validation (#6055) Co-authored-by: chatton <github.qpeyb@simplelogin.fr> (cherry picked from commit 50d2a08) # Conflicts: # CHANGELOG.md # modules/core/02-client/keeper/keeper.go # modules/core/02-client/keeper/keeper_test.go # modules/core/02-client/types/errors.go

mergify · 2024-06-10T13:10:04Z

Cherry-pick of 50d2a08 has failed:

On branch mergify/bp/08-wasm/release/v0.2.x+ibc-go-v8.3.x-wasmvm-v2.0.x/pr-6055
Your branch is up to date with 'origin/08-wasm/release/v0.2.x+ibc-go-v8.3.x-wasmvm-v2.0.x'.

You are currently cherry-picking commit 50d2a087.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   modules/core/02-client/abci.go
	modified:   modules/core/02-client/keeper/migrations.go
	modified:   modules/core/02-client/migrations/v7/genesis_test.go
	modified:   modules/core/02-client/proposal_handler.go
	modified:   modules/core/02-client/types/client.go
	modified:   modules/core/02-client/types/genesis_test.go
	modified:   modules/core/03-connection/keeper/handshake_test.go
	modified:   modules/core/genesis.go
	modified:   modules/core/keeper/keeper.go
	deleted:    modules/core/keeper/migrations.go
	modified:   modules/core/migrations/v7/genesis_test.go
	new file:   modules/light-clients/07-tendermint/consensus_host.go
	new file:   modules/light-clients/07-tendermint/consensus_host_test.go
	modified:   modules/light-clients/08-wasm/testing/simapp/app.go
	new file:   modules/light-clients/08-wasm/types/consensus_host.go
	new file:   modules/light-clients/08-wasm/types/consensus_host_test.go
	new file:   testing/mock/consensus_host.go
	modified:   testing/simapp/upgrades.go
	modified:   testing/simapp/upgrades/upgrades.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md
	both modified:   modules/core/02-client/keeper/keeper.go
	both modified:   modules/core/02-client/keeper/keeper_test.go
	both modified:   modules/core/02-client/types/errors.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

coderabbitai · 2024-06-10T13:11:18Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

damiannolan · 2024-06-10T14:45:27Z

waiting on #6563

…o mergify/bp/08-wasm/release/v0.2.x+ibc-go-v8.3.x-wasmvm-v2.0.x/pr-6055

damiannolan · 2024-06-11T13:49:49Z

This should be r4r now. Unassigning

damiannolan · 2024-06-11T14:10:59Z

modules/light-clients/08-wasm/types/consensus_host.go

+
+	wasmConsensusState := &ConsensusState{
+		Data: bz,
+	}


Note that this makes an assumption that the contract encodes consensus states with the wrapper envelope from 08-wasm. This is not currently mandated by 08-wasm, however it is mandated that the ClientState is wrapped in validatePostExecutionClientState()

…o mergify/bp/08-wasm/release/v0.2.x+ibc-go-v8.3.x-wasmvm-v2.0.x/pr-6055

mergify bot requested a review from colin-axner as a code owner June 10, 2024 13:10

mergify bot added the conflicts label Jun 10, 2024

mergify bot requested review from AdityaSripal, damiannolan, chatton, DimitrisJim, srdtrk and crodriguezvega as code owners June 10, 2024 13:10

damiannolan self-assigned this Jun 10, 2024

damiannolan added 2 commits June 11, 2024 15:35

Merge branch '08-wasm/release/v0.2.x+ibc-go-v8.3.x-wasmvm-v2.0.x' int…

069eb09

…o mergify/bp/08-wasm/release/v0.2.x+ibc-go-v8.3.x-wasmvm-v2.0.x/pr-6055

restore changes from release/v8.3.x

ceb7b16

damiannolan removed the conflicts label Jun 11, 2024

damiannolan removed their assignment Jun 11, 2024

damiannolan approved these changes Jun 11, 2024

View reviewed changes

damiannolan reviewed Jun 11, 2024

View reviewed changes

damiannolan added 2 commits June 12, 2024 17:03

Merge branch '08-wasm/release/v0.2.x+ibc-go-v8.3.x-wasmvm-v2.0.x' int…

4a78aec

…o mergify/bp/08-wasm/release/v0.2.x+ibc-go-v8.3.x-wasmvm-v2.0.x/pr-6055

chore: update changelog

343d058

DimitrisJim approved these changes Jun 12, 2024

View reviewed changes

crodriguezvega merged commit 427bf7f into 08-wasm/release/v0.2.x+ibc-go-v8.3.x-wasmvm-v2.0.x Jun 16, 2024
22 checks passed

crodriguezvega deleted the mergify/bp/08-wasm/release/v0.2.x+ibc-go-v8.3.x-wasmvm-v2.0.x/pr-6055 branch June 16, 2024 20:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: adding `ConsensusHost` interface for custom self client/consensus state validation (backport #6055) #6547

feat: adding `ConsensusHost` interface for custom self client/consensus state validation (backport #6055) #6547

mergify bot commented Jun 10, 2024

mergify bot commented Jun 10, 2024

coderabbitai bot commented Jun 10, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

damiannolan commented Jun 10, 2024

damiannolan commented Jun 11, 2024

damiannolan Jun 11, 2024

feat: adding ConsensusHost interface for custom self client/consensus state validation (backport #6055) #6547

feat: adding ConsensusHost interface for custom self client/consensus state validation (backport #6055) #6547

Conversation

mergify bot commented Jun 10, 2024

Description

Summary by CodeRabbit

mergify bot commented Jun 10, 2024

coderabbitai bot commented Jun 10, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

damiannolan commented Jun 10, 2024

damiannolan commented Jun 11, 2024

damiannolan Jun 11, 2024

Choose a reason for hiding this comment

feat: adding `ConsensusHost` interface for custom self client/consensus state validation (backport #6055) #6547

feat: adding `ConsensusHost` interface for custom self client/consensus state validation (backport #6055) #6547

CodeRabbit Configration File (`.coderabbit.yaml`)